Re: Server selection by weight flawed?

From: Ulric Eriksson <ulric_at_siag.nu>
Date: Tue, 27 Jun 2006 09:40:22 +0200 (CEST)

On Wed, 21 Jun 2006, Chris Elsworth wrote:

> Hello,
>
> I think I've found a logic problem in the pen code when you're using
> server selection by weight.
>
> I noticed that when using weighted servers, after a server temporarily
> died and came back, it wasn't used again.
>
> If I'm following the code properly this appears to be because
> try_server() is the function that marks servers as 'up' again, once
> it's successfully connected, but server_by_weight() will never return
> a broken server because of the status != 0 check. So broken servers
> are never retested.
>
> Am I reading that right?

You are right. I have released 0.17.1 which includes your patch.

Ulric
Received on Tue Jun 27 2006 - 09:40:24 CEST

This archive was generated by hypermail 2.2.0 : Tue Jun 27 2006 - 09:40:26 CEST